Opened 10 years ago
Closed 10 years ago
#22645 closed Bug (fixed)
Gis tests broken without a models.py
Reported by: | Florian Apolloner | Owned by: | Andrew Godwin |
---|---|---|---|
Component: | Migrations | Version: | dev |
Severity: | Normal | Keywords: | |
Cc: | Aymeric Augustin, Andrew Godwin | Triage Stage: | Accepted |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
This commit: https://github.com/django/django/commit/cebd8753c65ec33730f495bb7085f34884f7c3d6 broke the GIS tests with the following error: http://ci.djangoproject.com/job/Django/database=postgis,python=python2.7/4456/testReport/junit/django.contrib.gis.tests.gis_migrations.test_commands/MigrateTests/test_migrate_gis_2/ -- readding an empty models.py fixed it but should be considered as workaround.
Assigning to migrations, but could also be an app-refactor issue?
Change History (13)
comment:1 by , 10 years ago
Owner: | changed from | to
---|---|
Status: | new → assigned |
comment:3 by , 10 years ago
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
comment:4 by , 10 years ago
It's fine, this was just an overzealous check in MigrationLoader that I've removed.
comment:6 by , 10 years ago
Resolution: | fixed |
---|---|
Status: | closed → new |
comment:7 by , 10 years ago
Should we then simply change the comment? Removing These aliases are provided for backwards-compatibility.
?
comment:8 by , 10 years ago
comment:10 by , 10 years ago
I'm sorry, but I'm not so sure any more about recreating models.py
. The problem is that the presence of SpatialRefSys/GeometryColumns
is backend dependent, so adding them based on the default connection
object might break in case of multi-db setups where a non-default database has no such tables, like MySQL.
I've just tested removing the empty models.py
from django.contrib.gis
and the test suite now passes: https://github.com/django/django/pull/3724
comment:13 by , 10 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
I'll look into this. Probably a simple fix.