Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#22602 closed Cleanup/optimization (fixed)

Complete test coverage for makemigrations command

Reported by: Claude Paroz Owned by: Huu Nguyen
Component: Migrations Version: 1.7-beta-2
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: yes Patch needs improvement: no
Easy pickings: no UI/UX: no


Currently the coverage report of the makemigrations management command is only 61%. Let's try our best to extend this to 100% before releasing it.

Not blocking for the RC.

Change History (7)

comment:1 by Andrew Godwin, 10 years ago

I question this being marked as a release blocker at all; while I love test coverage as much as the next person, it doesn't find all the bugs, and trying to attain 100% coverage on a command that's very difficult to test because of the fact that it does filesystem operations is just going to slow us down.

Unless there's a convincing argument otherwise, I'd like to demote this from release blocker back down to normal.

Version 0, edited 10 years ago by Andrew Godwin (next)

comment:2 by Aymeric Augustin, 10 years ago

Severity: Release blockerNormal

100% coverage is rarely achievable (nor useful) for management commands. However, 41% is a bit low ;-)

comment:3 by mardini, 10 years ago

Needs tests: set

comment:4 by Huu Nguyen, 10 years ago

Owner: changed from nobody to Huu Nguyen
Status: newassigned

comment:5 by Huu Nguyen, 10 years ago

Has patch: set

Opened up a pull request for this here. Improved code coverage from 61% to 98%.

comment:6 by Tim Graham <timograham@…>, 10 years ago

Resolution: fixed
Status: assignedclosed

In f851a954ac605c4a525761a18d2dcbfb6f8deeca:

Fixed #22602 -- Improved code coverage of makemigrations command tests.

comment:7 by Tim Graham <timograham@…>, 10 years ago

In 8462883f9b16810fbc6175d78d7bb13a297debe9:

[1.7.x] Fixed #22602 -- Improved code coverage of makemigrations command tests.

Backport of f851a954ac from master

Note: See TracTickets for help on using tickets.
Back to Top