Opened 11 years ago
Closed 11 years ago
#22574 closed New feature (wontfix)
BrokenLinkEmailsMiddleware: send an email for all broken links, not just 404
| Reported by: | Jon Dufresne | Owned by: | nobody |
|---|---|---|---|
| Component: | Core (Other) | Version: | dev |
| Severity: | Normal | Keywords: | |
| Cc: | Triage Stage: | Unreviewed | |
| Has patch: | no | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
Broken links can exist in ways other than 404, such as 403 errors. The following patch modifies BrokenLinkEmailsMiddleware to send an email on all 4xx errors.
Attachments (1)
Change History (2)
by , 11 years ago
| Attachment: | all-4xx-broken-links.patch added |
|---|
comment:1 by , 11 years ago
| Resolution: | → wontfix |
|---|---|
| Status: | new → closed |
Thanks for the suggestion, but I don't think this is a good idea.
Firstly, I'm not wild about the idea of increasing the volume of email on any existing users that have this middleware installed.
Secondly, email notification isn't the right way to be handling this sort of reporting. BrokenLinkEmailsMiddleware is a big like a vestigial tail - it is a relic of an era when there wasn't tools like Sentry to do log analysis. I'd rather focus our efforts on integrating better with good logging and analysis tools, rather than expanding the capabilities of a feature that should probably be deprecated.
Lastly, if you *really* want 403's et al to reported by email, you can do this in your own code without difficulty.
If you'd like to advocate for this feature, feel free to open a discussion on the Django-developers mailing list.
patch