#22423 closed New feature (fixed)
Geodjango spatial functions should leverage mysql 5.6 spatial functions.
| Reported by: | visu | Owned by: | visu |
|---|---|---|---|
| Component: | GIS | Version: | dev |
| Severity: | Normal | Keywords: | gis, mysql, |
| Cc: | visumrs@… | Triage Stage: | Ready for checkin |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description (last modified by )
MySQL 5.6 and later implements spatial functions properly. (i.e., similar to PostGIS, mysql also supports ST_Contains, ST_Within and other ST_ queries.) http://dev.mysql.com/doc/refman/5.6/en/functions-for-testing-spatial-relations-between-geometric-objects.html#function_st-contains
Geodjango currently implements poly__contains and other queries for mysql as "MBRContains" instead of "Contains"
https://docs.djangoproject.com/en/dev/ref/contrib/gis/geoquerysets/#std:fieldlookup-gis-contains
related Ticket: #13430
Change History (15)
comment:1 by , 11 years ago
| Component: | Uncategorized → GIS |
|---|---|
| Has patch: | unset |
| Triage Stage: | Unreviewed → Accepted |
| Version: | 1.6 → master |
comment:2 by , 11 years ago
| Has patch: | set |
|---|---|
| Needs documentation: | set |
comment:3 by , 10 years ago
| Needs documentation: | unset |
|---|---|
| Patch needs improvement: | set |
I left comments for improvement on the PR. Please uncheck "Patch needs improvement" when you update it, thanks.
comment:4 by , 10 years ago
| Patch needs improvement: | unset |
|---|
https://github.com/django/django/pull/3941, MySQL 5.6.1+ testers welcome.
comment:5 by , 10 years ago
See the pull request for the remaining failure with test_disjoint_lookup.
comment:6 by , 10 years ago
| Patch needs improvement: | set |
|---|
comment:8 by , 9 years ago
The patch from #25659 has been committed, as it was orthogonal to this ticket.
comment:9 by , 6 years ago
This PR shows that MySQL is still failing with GeoLookupTest.test_disjoint_lookup, while MariaDB runs it fine. It's a bit sad that the entire patch is blocked just because of the MySQL disjoint issue. Any idea on the way to go forward?
Would it be acceptable to mark the text as expected failure on MySQL?
comment:12 by , 6 years ago
| Description: | modified (diff) |
|---|---|
| Triage Stage: | Accepted → Ready for checkin |
Hi,
I sent a pull request. Please review and let me know.
I attached a unit test in the pull request as well.
https://github.com/django/django/pull/2574
thanks,
Visu M