Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#22360 closed Bug (fixed)

Two admin_views tests are non-deterministic on Python 3.4 (dependent on dictionary key iteration order )

Reported by: Tim Graham Owned by: loic84
Component: Python 3 Version: 1.7-beta-1
Severity: Release blocker Keywords:
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

​Example failure on Jenkins.

admin_views.tests.AdminKeepChangeListFiltersTests.test_changelist_view and admin_views.tests.NamespacedAdminKeepChangeListFiltersTests.test_changelist_view fail when the expected and actual URLs differ in the order of the changelist_filters parameters, e.g. <a href="/test_admin/admin5/auth/user/104/?_changelist_filters=is_staff__exact%3D0%26is_superuser__exact%3D0"> vs. <a href="/test_admin/admin5/auth/user/104/?_changelist_filters=is_superuser__exact%3D0%26is_staff__exact%3D0">

Change History (4)

comment:1 by loic84, 10 years ago

Owner: changed from nobody to loic84
Status: new → assigned

comment:2 by Tim Graham <timograham@…>, 10 years ago

Resolution: → fixed
Status: assigned → closed

In 4d996b8e69c1374fd6ea2674384903456a74cc4b:

Fixed #22360 -- Fixed two non-deterministic tests in Python 3.4.

The order of admin's changelist filters in the querystring relied on
dict ordering.

comment:3 by Tim Graham <timograham@…>, 10 years ago

In 6405889a722580c01cf009159a2beb5b09e2fda0:

[1.7.x] Fixed #22360 -- Fixed two non-deterministic tests in Python 3.4.

The order of admin's changelist filters in the querystring relied on
dict ordering.

Backport of 4d996b8e69 from master

comment:4 by Tim Graham <timograham@…>, 10 years ago

In 07e2a5681435e493be93dceac611c3870ae6b1c6:

[1.6.x] Fixed #22360 -- Fixed two non-deterministic tests in Python 3.4.

The order of admin's changelist filters in the querystring relied on
dict ordering.

Backport of 4d996b8e69 from master

Note: See TracTickets for help on using tickets.
Back to Top