GeoQuerySet methods: support lookups on reversed o2o relationships as field_name
|Reported by:||pchiquet||Owned by:||anonymous|
|Cc:||mmitar@…, jernej@…||Triage Stage:||Accepted|
|Has patch:||yes||Needs documentation:||no|
|Needs tests:||no||Patch needs improvement:||yes|
GeoQuerySet methods, for example distance, are performed on a given geographic field of the model.
The geographic field to use can be specified thanks the field_name argument. field_name can be a field directly in the model or a lookup to a related field in another model (such as, 'address__point'). However lookups with reversed one to one relation are not supported.
For example, with the following model:
class User(Model): pass class UserProfile(NamedModel): user = models.OneToOneField(User) point = models.PointField()
the following spatial operation on User fails:
and raises the following exception:
Traceback (most recent call last): (...) File "django/contrib/gis/db/models/query.py", line 104, in distance return self._distance_attribute('distance', geom, **kwargs) File "django/contrib/gis/db/models/query.py", line 593, in _distance_attribute procedure_args, geo_field = self._spatial_setup(func, field_name=kwargs.get('field_name', None)) File "django/contrib/gis/db/models/query.py", line 466, in _spatial_setup raise TypeError('%s output only available on GeometryFields.' % func) TypeError: ST_Distance output only available on GeometryFields.
The lookup is supported only if the foreign key is in the Queryset model. I think it would be nice to support reversed relations too.
Change History (9)
comment:1 Changed 12 months ago by Pierre Chiquet
- Needs documentation unset
- Needs tests unset
- Owner changed from nobody to anonymous
- Patch needs improvement unset
- Status changed from new to assigned
comment:3 Changed 10 months ago by bmispelon
- Triage Stage changed from Unreviewed to Accepted
- Type changed from Bug to New feature