Opened 3 years ago

Closed 2 years ago

Last modified 2 years ago

#22336 closed Bug (fixed)

Impossible to exclude specific subdirectories with makemessages

Reported by: Ana Krivokapic Owned by: justhamade
Component: Core (Management commands) Version: master
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

As described in https://code.djangoproject.com/ticket/20422#comment:4, it is currently impossible to exclude subdirectories, or files in subdirectories, using the --ignore option of makemessages management command. This used to work in Django 1.5, but a regression was introduced by the fix for above mention ticket #20422.

The new patch should make sure to include unit tests which test for correct behavior of the --ignore option of makemessages, specifically in the case of subdirectories.

E.g:

makemessages --ignore dir/subdir/*
makemessages --ignore dir/*/file.py

etc.

Change History (9)

comment:1 Changed 3 years ago by ANUBHAV JOSHI

Needs documentation: unset
Needs tests: unset
Owner: changed from nobody to ANUBHAV JOSHI
Patch needs improvement: unset
Status: newassigned

comment:2 Changed 3 years ago by ANUBHAV JOSHI

Owner: ANUBHAV JOSHI deleted
Status: assignednew

There is some problem in running of makemessages in my django installation. So I am deassigning myself.

comment:3 Changed 2 years ago by justhamade

Owner: set to justhamade
Status: newassigned

comment:4 Changed 2 years ago by justhamade

comment:5 Changed 2 years ago by justhamade

Triage Stage: UnreviewedAccepted

comment:6 Changed 2 years ago by Claude Paroz <claude@…>

Resolution: fixed
Status: assignedclosed

In 8fe406864c5bbdd20e32d6127d377ed292006c5c:

Fixed #22336 -- Added path matching for makemessages ignore option

This fixes a regression introduced by 9012a9e200.

comment:7 Changed 2 years ago by Claude Paroz <claude@…>

In 98d6f128d0fd5aec0c8d49da273e369e8345a726:

[1.7.x] Fixed #22336 -- Added path matching for makemessages ignore option

This fixes a regression introduced by 9012a9e200.
Backport of 8fe406864c from master.

comment:8 Changed 2 years ago by Ramiro Morales <ramiro@…>

In b4dce7c37ab7666b023ac791d2c46dad6c8aa637:

Fixed #23298 -- Made makemessages actually ignore specified dirs on Windows.

This was detected by two failures in the i18n.test_extraction of our
test suite.

Refs #20422, refs #22336

comment:9 Changed 2 years ago by Tim Graham <timograham@…>

In 126606c5b8499830cd56cbe632f6af17bc7471ea:

[1.7.x] Fixed #23298 -- Made makemessages actually ignore specified dirs on Windows.

This was detected by two failures in the i18n.test_extraction of our
test suite.

Refs #20422, refs #22336

Backport of b4dce7c37a from master

Note: See TracTickets for help on using tickets.
Back to Top