#22315 closed Bug (fixed)
str/bytes mismatch in ManifestFilesMixin causes failure on Python 3
| Reported by: | David Evans | Owned by: | nobody |
|---|---|---|---|
| Component: | contrib.staticfiles | Version: | dev |
| Severity: | Normal | Keywords: | |
| Cc: | Triage Stage: | Accepted | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
The issue is that load_manifest returns bytes rather than a string which then gets fed into json.loads inside read_manifest resulting in:
TypeError: can't use a string pattern on a bytes-like object
read_manifest doesn't get exercised in the test suite, hence the issue not being spotted.
I'll try to submit a patch soon, but just registering the issue first.
Change History (4)
comment:1 by , 12 years ago
| Has patch: | set |
|---|
comment:2 by , 12 years ago
| Triage Stage: | Unreviewed → Accepted |
|---|
comment:3 by , 12 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Note:
See TracTickets
for help on using tickets.
Pull request here: https://github.com/django/django/pull/2463