Opened 13 months ago

Closed 13 months ago

Last modified 9 months ago

#22308 closed Bug (fixed)

Transaction-related test failures on MySQL

Reported by: aaugustin Owned by: aaugustin
Component: Database layer (models, ORM) Version: master
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Some tests that relied on internals of the legacy transaction management system fail after 0f956085.

I must have ported them incorrectly or introduced regressions. This is a release blocker for 1.8.

Change History (9)

comment:1 Changed 13 months ago by aaugustin

  • Owner changed from nobody to aaugustin
  • Status changed from new to assigned

comment:2 Changed 13 months ago by aaugustin

The three test failures I'm talking about are shown here:
http://ci.djangoproject.com/job/Django/database=mysql,python=python2.7/4219/testReport/

comment:3 Changed 13 months ago by Aymeric Augustin <aymeric.augustin@…>

In 0757e0f30d5ad3731d4a59fe571256369663c2f6:

Avoided transactional DDL on castrated databases.

Fixed a test failure that appeared after 753a22a6, although the bug
existed before that commit.

Refs #22308.

comment:4 Changed 13 months ago by Aymeric Augustin <aymeric.augustin@…>

In 6877a9d4156baa3a0c22288c7ef920915b6e1cf8:

Avoided transactional truncates on amateur databases.

Fixed a test failure that appeared after 753a22a6, although the bug
existed before that commit.

Refs #22308.

comment:5 Changed 13 months ago by aaugustin

The remaining failure comes from the test introduced in 2416e5fefe to fix #9479.

comment:6 Changed 13 months ago by Aymeric Augustin <aymeric.augustin@…>

  • Resolution set to fixed
  • Status changed from assigned to closed

In b66e85342b6ab28b7f48b47fe3fcfbccd5d9943f:

Fixed #22308 -- Regression from 0f956085.

Rewrote the test for #9479 according to the original ticket.

comment:7 Changed 9 months ago by Tim Graham <timograham@…>

In 2a97db33a79c0be179b5bc35860400287f1ae26a:

[1.7.x] Avoided transactional DDL on castrated databases.

Fixed a test failure that appeared after 753a22a6, although the bug
existed before that commit.

Refs #22308 and #23089.

Backport of 0757e0f30d from master

comment:8 Changed 9 months ago by Tim Graham <timograham@…>

In 0ac986fd8cb2561a22aa3291672723b50397e5ac:

[1.7.x] Avoided transactional truncates on amateur databases.

Fixed a test failure that appeared after 753a22a6, although the bug
existed before that commit.

Refs #22308.

Backport of 6877a9d4 from master

comment:9 Changed 9 months ago by Tim Graham <timograham@…>

In 83098dccdf3172302cde54e11c36050c1d83f996:

[1.6.x] Fixed #23089 -- Fixed transaction handling in two management commands.

Previously, when createcachetable and flush operated on non-default
databases, they weren't atomic.

Also avoided transactional DDL and transactional truncates on databases
that don't support them (refs #22308).

Backport of 753a22a635, 0757e0f30d, and 6877a9d415 from master

Note: See TracTickets for help on using tickets.
Back to Top