#22299 closed Cleanup/optimization (fixed)
Wizard storage should delete temp files when reset
Reported by: | Simon Charette | Owned by: | nobody |
---|---|---|---|
Component: | contrib.formtools | Version: | dev |
Severity: | Normal | Keywords: | |
Cc: | Triage Stage: | Ready for checkin | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
In order to keep reference to files uploaded through forms during a step submission files are temporally stored using the declared file_storage
.
As documented, those temporary files are never deleted, even upon wizard reset or completion.
I understand that it's not possible to clean temporary files in all cases (i.e. incomplete wizard) but I think we should try to cleanup after ourselves when possible. That is when storage.reset
is explicitly called.
Attaching a PR with a test and a documentation admonition.
Change History (5)
comment:1 by , 11 years ago
comment:2 by , 11 years ago
Triage Stage: | Unreviewed → Accepted |
---|
comment:3 by , 11 years ago
Triage Stage: | Accepted → Ready for checkin |
---|
Looks fine to me. With updated pull request, tests succeed on Python 2 and 3.
comment:4 by , 11 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
See https://github.com/django/django/pull/2451