admin/base.html only shows #user-tools when user is staff
|Reported by:||wouter@…||Owned by:||Tim Graham <timograham@…>|
|Severity:||Normal||Keywords:||user-tools admin base template|
|Cc:||jeffrey@…, tanner||Triage Stage:||Ready for checkin|
|Has patch:||yes||Needs documentation:||no|
|Needs tests:||no||Patch needs improvement:||no|
The build-in Django Admin ships with the admin/base.html template. This template is, among other things, responsible for rendering the #user-tools div that contains the 'log out' and 'change password' buttons. The user tools are only rendered if user.is_active and user.is_staff are True, see:
This check makes sure that #user-tools is only rendered when the user is actually authenticated for use of the admin. This is required because the login template (admin/login.html) eventually inherits from admin/base.html. If the check would be omitted, the #user-tools would become visible if the user was yet to be authenticated resulting in a situation where the user could 'log out' without being 'logged in' first.
This check is therefore relevant, but is it the wrong check and breaks inheritance in the following case:
Lets say you want to inherit from django.contrib.admin.sites.BaseSite to create a customized admin for special users that are not necessarily staff members. You can override the BaseSite.has_permission method. Currently this method holds the condition: request.user.is_active and request.user.is_staff . You might change this to request.user.is_active and request.user.is_a_special_user_but_not_staff . This user would now be allowed to access this customised admin without having access to the default admin.
The problem is that the user cannot log out from this special admin because the #user-tools are only rendered if the user is a staff member.
I can think of two solutions:
- Use the BaseAdmin.has_permission to do this check
- Create a block called user-tools in the template and override this block in the admin/login.html to be empty
In my opinion solution number 2 would be the best approach :-).
Change History (13)
comment:1 Changed 2 years ago by aaugustin
- Needs documentation unset
- Needs tests unset
- Patch needs improvement unset
comment:3 Changed 21 months ago by maxocub
- Owner changed from nobody to maxocub
- Status changed from new to assigned
comment:6 Changed 16 months ago by maxocub
- Owner maxocub deleted
- Status changed from assigned to new
comment:12 Changed 14 months ago by timgraham
- Triage Stage changed from Accepted to Ready for checkin