#2228 closed enhancement (wontfix)
[patch] Add e-mail and URL to free comments
| Reported by: | Owned by: | Adrian Holovaty | |
|---|---|---|---|
| Component: | contrib.comments | Version: | |
| Severity: | normal | Keywords: | |
| Cc: | tyson@… | Triage Stage: | Design decision needed |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | UI/UX: |
Description
Replaces #2184 due to comment spam.
This patch adds the ability for comments to accept a person's e-mail address and/or URL, optionally. This is a feature found in most comment systems and would be very useful in Django.
The current patch doesn't validate e-mail addresses or URLs, because I'm not too sure where I should do that.
Attachments (5)
Change History (21)
Changed 17 years ago by
| Attachment: | better_comments.diff added |
|---|
comment:1 Changed 17 years ago by
EmailField and URLField both have their own validation routines baked in; EmailField makes sure you've entered something that looks like an email address (though it won't email to validate for you; that'd be something that could be developed on a per-case basis), and URLField checks the format of the URL and, by default, hits it to make sure it exists.
comment:2 Changed 17 years ago by
| Cc: | tyson@… added |
|---|
I set up a small test app, and was able to enter "x" for all fields (name, e-mail, url, comment), and both e-mail and url were accepted as "x" and displayed as "x". In the database, they were stored as "x".
Is there someplace that I should set-up proper validation? I think it might be handy that, if a developer adds the e-mail and url fields, the fields get validated like the name field is checked for emptiness.
I'll attach my sample project.
Changed 17 years ago by
| Attachment: | comment_test.zip added |
|---|
Sample use of free comments with e-mail and URL.
comment:3 Changed 17 years ago by
Hi Tyson, +1 from me (FWIW :-) on this, you're absolutely right IMHO that free comments ought to support email address & URL.
Regarding the validation issue, you probably want to change django/contrib/comments/views/comments.py so that it instantiates a forms.URLField and a forms.EmailField, instead of two plain TextFields.
-greg a.
Changed 17 years ago by
| Attachment: | better_comments2.diff added |
|---|
Changed from TextField to proper fields and, by consequence, adds proper error checking
comment:4 Changed 17 years ago by
A hah! I knew I was missing something simple. I've uploaded a better patch and an updated comment test project. I've tried messing it up in a number of ways, but it looks pretty fool-proof now.
Thanks, Greg!
comment:5 Changed 17 years ago by
| Cc: | hi-world cup added; tyson@… removed |
|---|---|
| Keywords: | rthml tab space editor js added |
| Summary: | [patch] Add e-mail and URL to free comments → hi-world cup |
comment:6 Changed 17 years ago by
| Cc: | hi-world cup removed |
|---|---|
| Summary: | hi-world cup → [patch] Add e-mail and URL to free comments |
comment:7 Changed 17 years ago by
| Cc: | tyson@… added |
|---|---|
| Keywords: | rthml tab space editor js removed |
Stupid spam. *grumble grumble*
comment:8 Changed 16 years ago by
| Component: | Contrib apps → django.contrib.comments |
|---|
comment:9 Changed 16 years ago by
| Triage Stage: | Unreviewed → Accepted |
|---|
comment:10 Changed 16 years ago by
| Resolution: | → wontfix |
|---|---|
| Status: | new → closed |
Jacob is rewriting the comments app for 1.0, so it isn't worth applying this and taking the compatibility hit for just one release.
comment:12 Changed 16 years ago by
| Component: | django.contrib.comments → Database wrapper |
|---|---|
| Keywords: | fitness equipment health and fitness added |
| Triage Stage: | Accepted → Design decision needed |
| Version: | → new-admin |
comment:13 Changed 16 years ago by
| Keywords: | fitness equipment health and fitness removed |
|---|---|
| Version: | new-admin |
spam cleanup
comment:14 Changed 16 years ago by
| Component: | Database wrapper → django.contrib.comments |
|---|
Changed 15 years ago by
| Attachment: | better_comments3.diff added |
|---|
Simply an update of the diff file for more recent releases.
Adds e-mail and URL capability