Admin shows selected rows as "<amount> of undefined selected"

[Bas Peschier]

Commit ​https://github.com/django/django/commit/4523fcd60101124a307bd4026296337087b66884 introduces _actions_icnt to the local scope, which overrides the value set in the HTML.

The admin will show selected rows in a change list as "1 of undefined selected".

PR under ​https://github.com/django/django/pull/2274; looking into a test.

[Baptiste Mispelon]

Hi,

Th PR looks good but it'd be better with some tests.
I was also thinking it might be wise to add a comment on the line where _actions_icnt is used to indicate that the lack of declaration is on purpose.

I'll mark this as release blocker as well so that it doesn't slip through the cracks.

Thanks for catching this.

[Claude Paroz]

Tim merged the PR in 83a3add4bed8d8d49f93b30c817c66908b0a26ba. A test would be nice.

[Baptiste Mispelon]

the modified js file should also be minified: ​https://docs.djangoproject.com/en/1.6/internals/contributing/writing-code/submitting-patches/#compressing-javascript

[Bas Peschier]

Sent a new PR which documents the variable, adds a test and minifies the Javascript: ​https://github.com/django/django/pull/2340

[Baptiste Mispelon <bmispelon@…>]

In 578bdb532cd88333569ef3f77042653e1a9f2d9d:

Added tests and minified javascript missing in 83a3add4bed8d8d49f93b30c817c66908b0a26ba.

Refs #22038.

[Bas Peschier]

And that commit actually fixed it