Opened 5 years ago

Closed 5 years ago

#22024 closed Cleanup/optimization (invalid)

there are no tests for assertContains

Reported by: Harry Percival Owned by: Harry Percival
Component: Utilities Version: 1.6
Severity: Normal Keywords:
Cc: Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no


I've been thinking of ways to tweak assertContains, thought about trying a couple of them out, and was shocked, shocked to discover that this test helper method has no tests of its own!

Change History (4)

comment:1 Changed 5 years ago by anonymous

in case the trac github plugin magic doesn't work, here's the PR

comment:2 Changed 5 years ago by Baptiste Mispelon


What about test_client_regress.tests.AssertContainsTests and test_utils.tests.HTMLEqualTests?

They seem to be testing the behavior of assertContains to me (I found them by changing assertContains to always return True and running the full test suite to see what broke).

comment:3 Changed 5 years ago by anonymous

aha! well, i guess i should have tried that :) let's have a look...

comment:4 Changed 5 years ago by Harry Percival

Resolution: invalid
Status: newclosed

right-o. my bad!

Note: See TracTickets for help on using tickets.
Back to Top