#2202 closed enhancement (fixed)
[patch] Added optional argument to template filter "pluralize"
| Reported by: | Owned by: | Adrian Holovaty | |
|---|---|---|---|
| Component: | Template system | Version: | dev |
| Severity: | minor | Keywords: | |
| Cc: | Triage Stage: | Unreviewed | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
Makes the following valid in a template: {{ tomatoes|pluralize:"es" }}
Attachments (2)
Change History (10)
Changed 17 years ago by
| Attachment: | optional_argument_to_pluralize_template_filter.diff added |
|---|
comment:1 Changed 17 years ago by
comment:2 Changed 17 years ago by
The pluralize filter is a very simple 80% solution. This patch makes it more of an 85% solution, which I'm comfortable with. It just needs docs -- then it can be committed.
comment:3 Changed 17 years ago by
| Owner: | changed from Adrian Holovaty to anonymous |
|---|---|
| Status: | new → assigned |
comment:4 Changed 17 years ago by
| Owner: | changed from anonymous to Adrian Holovaty |
|---|---|
| Status: | assigned → new |
comment:5 Changed 17 years ago by
| Status: | new → assigned |
|---|
Changed 17 years ago by
| Attachment: | optional_arguments_to_pluralize.patch added |
|---|
Pluralize with optional arguments (tests and documentation included)
comment:6 Changed 17 years ago by
This patch allows for plural/singular alternatives too, so you can have your knife/knives.
comment:7 Changed 17 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
comment:8 Changed 17 years ago by
Note: See
TracTickets for help on using
tickets.
I dunno. The pluralize filter is a bad hack - it can't handle cases where the plural isn't formed by tacking something onto the end of the singular, e.g. man/men or knife/knives. There's a fair few of these cases in English, and it's the default in many languages.
AFAIK you can't pass more than one extra argument to a filter, so I don't think pluralize is fixable. If you care at all about grammatical correctness, you probably shouldn't be using it.