#21937 closed New feature (invalid)

Add forms_valid for the mixin to work with django-extra-view's UpdateWithInlinesView

Reported by: david.fischer.ch@… Owned by: nobody
Component: contrib.messages Version: master
Severity: Normal Keywords: extra-views, mixin
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

For my own purposes I am using on of the mixins of the project called django-extra-views.

This mixin uses a method called forms_valid that was missing to allow using the messages framework too.

Attachments (1)

0001-Add-forms_valid-for-the-mixin-to-work-with-django-ex.patch (1.1 KB) - added by david.fischer.ch@… 19 months ago.
The patch for this contribution

Download all attachments as: .zip

Change History (2)

Changed 19 months ago by david.fischer.ch@…

The patch for this contribution

comment:1 Changed 19 months ago by mjtamlyn

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Resolution set to invalid
  • Status changed from new to closed

This patch would more logically live in django-extra-views, providing an overridden version of SuccessMessageMixin. We cannot possibly support all possible external packages in this way.

Note: See TracTickets for help on using tickets.
Back to Top