Opened 11 years ago
Closed 11 years ago
#21937 closed New feature (invalid)
Add forms_valid for the mixin to work with django-extra-view's UpdateWithInlinesView
| Reported by: | Owned by: | nobody | |
|---|---|---|---|
| Component: | contrib.messages | Version: | dev |
| Severity: | Normal | Keywords: | extra-views, mixin |
| Cc: | Triage Stage: | Unreviewed | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
| Pull Requests: | How to create a pull request | ||
Description ¶
For my own purposes I am using on of the mixins of the project called django-extra-views.
This mixin uses a method called forms_valid that was missing to allow using the messages framework too.
Change History (2)
by , 11 years ago
| Attachment: | 0001-Add-forms_valid-for-the-mixin-to-work-with-django-ex.patch added |
|---|
comment:1 by , 11 years ago
| Resolution: | → invalid |
|---|---|
| Status: | new → closed |
This patch would more logically live in django-extra-views, providing an overridden version of SuccessMessageMixin. We cannot possibly support all possible external packages in this way.
Note:
See TracTickets
for help on using tickets.
The patch for this contribution