#21847 closed Uncategorized (fixed)

Missing Import (Docs)

Reported by: anonymous Owned by: knitatoms
Component: Documentation Version: 1.6
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

Contact Form is used in the view but it wasn't imported.

https://docs.djangoproject.com/en/1.6/topics/forms/#using-a-form-in-a-view

Thank you.

Change History (3)

comment:1 Changed 18 months ago by bmispelon

  • Component changed from Forms to Documentation
  • Easy pickings set
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

Hi,

I'll mark this as accepted because it might be confusing if you arrive to that section without having read the previous paragraph.

The problem here is that ContactForm doesn't live in a particular module: it's just an example form from the section just above.
Without adding an import statement, maybe it would be enough to just mention that ContactForm was defined in the previous section.

What do you think?

comment:2 Changed 18 months ago by knitatoms

  • Owner changed from nobody to knitatoms
  • Status changed from new to assigned

Agreed - I've submitted a pull request on GitHub: https://github.com/django/django/pull/2206

comment:3 Changed 18 months ago by Tim Graham <timograham@…>

  • Resolution set to fixed
  • Status changed from assigned to closed

In 3b869b09d084eb486c936ac4b528e288ceec83d5:

Fixed #21847 -- Clarified where ContactForm was defined

Note: See TracTickets for help on using tickets.
Back to Top