#21825 closed Uncategorized (fixed)

GIS compiler doesn't adhere to query expression api

Reported by: smeatonj Owned by: nobody
Component: Database layer (models, ORM) Version: master
Severity: Normal Keywords: lookups
Cc: Triage Stage: Unreviewed
Has patch: no Needs documentation:
Needs tests: Patch needs improvement:
Easy pickings: no UI/UX: no

Description

The new query expression API defines as_sql as as_sql(qn, connection), but has this note:

The qn has a compile() method that can be used to compile other expressions

See: https://docs.djangoproject.com/en/dev/ref/models/custom-lookups/#django.db.models.as_sql

The GIS compiler explicitly passes the quote_name function rather than itself.

Change History (1)

comment:1 Changed 18 months ago by Anssi Kääriäinen <akaariai@…>

  • Resolution set to fixed
  • Status changed from new to closed

In 1f58834ac6858aa33629a27cb252de00141e76b0:

Fixed #21825 -- gis compiler uses self instead of qn for as_sql()

Note: See TracTickets for help on using tickets.
Back to Top