#21714 closed Cleanup/optimization (fixed)

Move LazySettings._configure_logging to django.setup

Reported by: aaugustin Owned by: claudep
Component: Core (Other) Version: master
Severity: Normal Keywords: app-loading
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Since Django now has an explicit entrypoint, there's no reason to handle logging in the settings anymore.

Change History (7)

comment:1 Changed 19 months ago by mjtamlyn

  • Triage Stage changed from Unreviewed to Accepted

comment:2 Changed 19 months ago by claudep

  • Owner changed from nobody to claudep
  • Status changed from new to assigned

comment:4 Changed 19 months ago by aaugustin

Could you define configure_logging in another module, for example in django.utils.logging?

django.__init__ should only put the pieces together.

comment:5 Changed 19 months ago by claudep

PR updated.

comment:6 Changed 19 months ago by aaugustin

  • Triage Stage changed from Accepted to Ready for checkin

LGTM

comment:7 Changed 19 months ago by Claude Paroz <claude@…>

  • Resolution set to fixed
  • Status changed from assigned to closed

In b8e3373f458aa363d59c61b58be390a5a1156467:

Fixed #21714 -- Moved logging configuration to global setup()

Thanks Aymeric Augustin for the report and the review.

Note: See TracTickets for help on using tickets.
Back to Top