Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#21690 closed Uncategorized (invalid)

Confusing statement regarding the ADMIN_MEDIA_PREFIX.

Reported by: Val Neekman Owned by: nobody
Component: Documentation Version: 1.6
Severity: Normal Keywords: admin media
Cc: vneekman@… Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Confusing statement regarding the ADMIN_MEDIA_PREFIX.

On this page:
https://docs.djangoproject.com/en/1.6/releases/1.4/#django-contrib-admin

(A) It says:
"This setting has now been deprecated and replaced by the more general setting STATIC_URL.".

(B) Then few lines later it says:
"If your ADMIN_MEDIA_PREFIX is set to an specific domain (e.g. http://media.example.com/admin/), make sure to also set your STATIC_URL setting to the correct URL – for example, http://media.example.com/."

--
Now: which one is it. Deprecated or not?
If ADMIN_MEDIA_PREFIX is deprecated, then its reference in (B) should either be removed or changed to "If your ADMIN_MEDIA_PREFIX was ..."

Change History (4)

comment:1 Changed 3 years ago by Aymeric Augustin

Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset

ADMIN_MEDIA_PREFIX is gone.

comment:2 Changed 3 years ago by Val Neekman

ADMIN_MEDIA_PREFIX is gone, while an improper reference to it still exist which needs to be removed.

Something like the following will do it.


This line:

"If your ADMIN_MEDIA_PREFIX is set to an specific domain (e.g. http://media.example.com/admin/), make sure to also set your STATIC_URL setting to the correct URL – for example, http://media.example.com/."

Should be changed to:

If your STATIC_URL is set to an specific domain (e.g. http://media.example.com/), make sure your admin media files are accessable at, for example, http://media.example.com/admin/.

comment:3 Changed 3 years ago by Tim Graham

Resolution: invalid
Status: newclosed

Thanks for the report, but I don't think it's confusing if you realize this reference is part of the 1.4 release notes. It's appropriate for people upgrading to 1.4 from an older release (where ADMIN_MEDIA_PREFIX exists).

comment:4 Changed 3 years ago by Val Neekman

Oh, I see.

I was on 1.4 version of the documentation, clicked on 1.6 version (bottom right of the browser) to see if the docs have been updated and it switched to 1.6. At least the bottom right of the page was showing 1.6.

That is why I was confused and thought it was really on 1.6 and that it was a leftover artifact from 1.4 that needed to be updated.

No worries.

Thx

Note: See TracTickets for help on using tickets.
Back to Top