Opened 10 years ago
Closed 10 years ago
#21677 closed Cleanup/optimization (fixed)
Review Apps.get_model[s]
| Reported by: | Aymeric Augustin | Owned by: | nobody |
|---|---|---|---|
| Component: | Core (Other) | Version: | dev |
| Severity: | Normal | Keywords: | app-loading |
| Cc: | Triage Stage: | Accepted | |
| Has patch: | no | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
Following the recent work on the app loading project, it would be useful to review, and possibly optimize, the implementation of these methods and to add tests (probably based on https://code.djangoproject.com/attachment/ticket/3591/app-loading.2.diff#L1827).
Change History (5)
comment:1 by , 10 years ago
| Triage Stage: | Unreviewed → Accepted |
|---|
comment:2 by , 10 years ago
comment:4 by , 10 years ago
only_installed is gone: https://github.com/django/django/compare/81a5e35c8d35...9f13c3328199
Now the next step is to change get_models to stop taking an models module as first argument.
comment:5 by , 10 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
As of 34a215d5066f8ae0629070916714801b0ea03eab this is done.
Note:
See TracTickets
for help on using tickets.
Have a look at get_migratable_models too.