Simplify find_management_module

[Aymeric Augustin]

There's a comment that says: "When using manage.py, the project module is added to the path, loaded, then removed from the path."

I believe manage.py no longer does that since 1.4 (new project layout). As a consequence the code could be simplified.

[Ramiro Morales]

Thought the same when trying to work on #15084 and reviewing that code.

But, shouldn't that code remain as is to stay compatible with existing project that use old the layout? Or this isn't a supported scenario?

[Marc Tamlyn]

I think we've had the new layout long enough - other things which tried to do clever stuff around this have been removed from what I remember. +1 to removing this.

[Claude Paroz]

Is this too much simplification?

[Aymeric Augustin]

Yes, your approach seems correct to me. I'd rather remove this stuff and see if someone has an edge case that breaks than leave it without knowing why. The patch will require a small update to apply after 486532. I'll let you push it!

[Aymeric Augustin]

Replying to ramiro:

But, shouldn't that code remain as is to stay compatible with existing project that use old the layout? Or this isn't a supported scenario?

Because of the app-loading refactor, I don't think it'll be possible to use the old layout with Django 1.7.

[Claude Paroz <claude@…>]

In fe53bc524b9c7cbc814868acde94226d0ba2bc84:

Fixed #21630 -- Simplified management command discovery

Thanks Aymeric Augustin for the report end the review.

[Claude Paroz]

I'm not convinced this has to be backported to 1.7. If you think it should, just speak!

[Aymeric Augustin]

Yes, I think it should be backported, because if it breaks something, that will be seen as collateral damage of app loading.

[Claude Paroz <claude@…>]

In 91ef348bd6ac5d3051d428806b143c419af91aa8:

[1.7.x] Fixed #21630 -- Simplified management command discovery

Thanks Aymeric Augustin for the report end the review.
Backport of fe53bc524 from master.

[Aymeric Augustin]

Thank you!