Code

Opened 4 months ago

Closed 4 months ago

Last modified 4 months ago

#21613 closed Cleanup/optimization (fixed)

Misleading hardcoded input id in tutorial

Reported by: claudep Owned by: AnneTheAgile
Component: Documentation Version: master
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

https://docs.djangoproject.com/en/dev/intro/tutorial04/

That means, when somebody selects one of the radio buttons and submits the form, it’ll send the POST data choice=3.

Apparently, nothing forces the value to be 3. We should rephrase this sentence.

Attachments (0)

Change History (7)

comment:1 Changed 4 months ago by claudep

Oh, credit to Bruno Brouard for spotting this issue.

comment:2 Changed 4 months ago by AnneTheAgile

  • Owner changed from nobody to AnneTheAgile
  • Status changed from new to assigned

comment:3 Changed 4 months ago by AnneTheAgile

See Pull Request,
https://github.com/django/django/pull/2078
My comment #21613 , Clarified the previously mysterious magic constant '3'. I researched a bit and there are '3' default choices available, https://docs.djangoproject.com/en/dev/intro/tutorial02/ .

comment:4 Changed 4 months ago by Tim Graham <timograham@…>

  • Resolution set to fixed
  • Status changed from assigned to closed

In cc2d9602746395d5f406632139378d469ca6301b:

Fixed #21613 -- Removed a hardcoded input id from the tutorial.

Thanks Bruno Brouard for the report.

comment:5 Changed 4 months ago by Tim Graham <timograham@…>

In 6980059af2835ed3d15b4a59e16321bc8d828c0e:

[1.5.x] Fixed #21613 -- Removed a hardcoded input id from the tutorial.

Thanks Bruno Brouard for the report.

Backport of cc2d960274 from master

comment:6 Changed 4 months ago by Tim Graham <timograham@…>

In 07d3d57dedbc2baf8d704d32f3d48523d2991b9e:

[1.6.x] Fixed #21613 -- Removed a hardcoded input id from the tutorial.

Thanks Bruno Brouard for the report.

Backport of cc2d960274 from master

comment:7 Changed 4 months ago by AnneTheAgile

yay, I'm glad the fix is approved. I was thinking of just writing "#" as done in the accepted change, but thought maybe it wouldn't be accepted and so was trying to rewrite the text around it. I deleted my branch. Thank you for your patience with me and question-answering !

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.