Opened 3 years ago

Closed 3 years ago

#21610 closed Bug (fixed)

Broken link on "Community" page

Reported by: Baptiste Mispelon Owned by: ekevin
Component: *.djangoproject.com Version: master
Severity: Normal Keywords:
Cc: ANUBHAV JOSHI Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: yes UI/UX: no

Description

On the side bar of the "Community" page [1], the link explaining how to sign up to our mailing lists without a Google account is broken.

The offending line is on line 31 of templates/community_base.html [2]

[1] https://www.djangoproject.com/community/
[2] https://github.com/django/djangoproject.com/blob/master/templates/base_community.html#L31

Change History (7)

comment:1 Changed 3 years ago by Claude Paroz

I would suggest to link django-users to https://docs.djangoproject.com/en/dev/internals/mailing-lists/#django-users (or backport the page to 1.6 and link to /stable/), remove the subscribing form on the community page (and the FAQ link also). The same for django-developers.

comment:2 Changed 3 years ago by ANUBHAV JOSHI

Cc: ANUBHAV JOSHI added

I think we should just remove the form fields from sidebar and just give the link to the page ​https://docs.djangoproject.com/en/dev/internals/mailing-lists/#django-users for django-users and ​https://docs.djangoproject.com/en/dev/internals/mailing-lists/#django-developers for django-developers. That would be the best way as it would require minimal changes and is also suitable.

comment:3 Changed 3 years ago by ekevin

Owner: changed from nobody to ekevin
Status: newassigned

comment:4 Changed 3 years ago by Baptiste Mispelon

Has patch: set
Patch needs improvement: set

There's a PR here: https://github.com/django/djangoproject.com/pull/67

Note to kevin_e: make sure you post a comment on trac when you create a pull request next time since not all of us subscribe to github alerts (I found your pull request by accident)

I left a comment on it but other than that I think it looks good.

Once that small issue is fixed, you can remove the patch needs improvement flag is set the ticket to ready for checkin.

Thanks

comment:5 Changed 3 years ago by ANUBHAV JOSHI

kevin_e
Please see the comments on your pull request.
Change /dev/ to /1.6/ in the links to the mailing lists.

comment:6 Changed 3 years ago by ANUBHAV JOSHI

comment:7 Changed 3 years ago by Baptiste Mispelon <bmispelon@…>

Resolution: fixed
Status: assignedclosed

In 569401fc932f5647fc3446b2fa81d693612f10fb/djangoproject.com:

Fixed #21610 -- Removed broken link on Community page

Removed subscribing form and FAQ link and updated link for django-users
and django-developers to go to 'Mailing lists' webpage.

Thanks bmispelon for the report and claudep and anubhav9042 for the
review.

Note: See TracTickets for help on using tickets.
Back to Top