#21594 closed Cleanup/optimization (fixed)
Add note to docs about model formsets deleting objects on save with commit=False
| Reported by: | Ben Spaulding | Owned by: | nobody |
|---|---|---|---|
| Component: | Documentation | Version: | 1.6 |
| Severity: | Normal | Keywords: | |
| Cc: | Triage Stage: | Accepted | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | yes |
| Easy pickings: | yes | UI/UX: | no |
Description
Some users may interpret commit=False to mean that no changes are commited to the database, when deletions actually are (as far as I understand).
Patch at Pull Request #2062
Change History (8)
follow-up: 2 comment:1 by , 10 years ago
| Triage Stage: | Unreviewed → Accepted |
|---|---|
| Version: | master → 1.6 |
comment:2 by , 10 years ago
Replying to charettes:
As pointed out on the PR it seems like this should be fixed in the future 1.7.x release (see #10284).
Thanks for pointing that out. I searched for related tickets, but I guess I only searched open tickets, so I did not see #10284.
Accepting because it might cause unexpected data losses and be worth the backport effort to the documentation of previous releases.
That sounds good. Do you need me to modify the pull request, or create a new one that puts that note in stable/1.6.x, or just attach a patch in Trac? Let me know how I can help.
Thanks!
comment:3 by , 10 years ago
Please open a new PR against stable/1.6.x with the additional note that it has been fixed in Django 1.7.
comment:4 by , 10 years ago
| Patch needs improvement: | set |
|---|---|
| Type: | Uncategorized → Cleanup/optimization |
comment:6 by , 10 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
As pointed out on the PR it seems like this should be fixed in the future 1.7.x release (see #10284).
Accepting because it might cause unexpected data losses and be worth the backport effort to the documentation of previous releases.