Opened 16 months ago

Closed 16 months ago

Last modified 16 months ago

#21594 closed Cleanup/optimization (fixed)

Add note to docs about model formsets deleting objects on save with commit=False

Reported by: benspaulding Owned by: nobody
Component: Documentation Version: 1.6
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: yes UI/UX: no

Description

Some users may interpret commit=False to mean that no changes are commited to the database, when deletions actually are (as far as I understand).

Patch at Pull Request #2062

Change History (8)

comment:1 follow-up: Changed 16 months ago by charettes

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted
  • Version changed from master to 1.6

As pointed out on the PR it seems like this should be fixed in the future 1.7.x release (see #10284).

Accepting because it might cause unexpected data losses and be worth the backport effort to the documentation of previous releases.

comment:2 in reply to: ↑ 1 Changed 16 months ago by benspaulding

Replying to charettes:

As pointed out on the PR it seems like this should be fixed in the future 1.7.x release (see #10284).

Thanks for pointing that out. I searched for related tickets, but I guess I only searched open tickets, so I did not see #10284.

Accepting because it might cause unexpected data losses and be worth the backport effort to the documentation of previous releases.

That sounds good. Do you need me to modify the pull request, or create a new one that puts that note in stable/1.6.x, or just attach a patch in Trac? Let me know how I can help.

Thanks!

comment:3 Changed 16 months ago by charettes

Please open a new PR against stable/1.6.x with the additional note that it has been fixed in Django 1.7.

comment:4 Changed 16 months ago by charettes

  • Patch needs improvement set
  • Type changed from Uncategorized to Cleanup/optimization

comment:5 Changed 16 months ago by benspaulding

New pull request against stable/1.6.x, #2063.

comment:6 Changed 16 months ago by Simon Charette <charette.s@…>

  • Resolution set to fixed
  • Status changed from new to closed

In de1d5d5df5238136e8cd114e36065857bee1ace4:

[1.6.x] Fixed #21594 -- Added note about model formsets deleting objects.

This behavior has been fixed in 65e03a424e. refs #10284.

comment:7 Changed 16 months ago by Simon Charette <charette.s@…>

In a53820b1b1747d6f9b5ee5723aa7526ededdaba7:

[1.5.x] Fixed #21594 -- Added note about model formsets deleting objects.

This behavior has been fixed in 65e03a424e. refs #10284.

Backport of de1d5d5df5 from stable/1.6.x.

comment:8 Changed 16 months ago by Simon Charette <charette.s@…>

In 474e7dd6d08105fce66d7f62670a6c120c0b1198:

[1.4.x] Fixed #21594 -- Added note about model formsets deleting objects.

This behavior has been fixed in 65e03a424e. refs #10284.

Backport of de1d5d5df5 from stable/1.6.x.

Note: See TracTickets for help on using tickets.
Back to Top