Generic base view http_method_not_allowed method references self.request and should use locally scoped request

[Adam DePue]

The current method in django/views/generic/base.py is:

     def http_method_not_allowed(self, request, *args, **kwargs):                         
         logger.warning('Method Not Allowed (%s): %s', request.method, request.path,      
             extra={                                                                      
                 'status_code': 405,                                                      
                 'request': self.request                                                  
             }                                                                            
         )                                                                                
         return http.HttpResponseNotAllowed(self._allowed_methods())                      

The 'extra' dictionary should reference the locally scoped 'request' object instead of the class scoped member.

There is a PR open with this fix:
​https://github.com/django/django/pull/2035

The side effect is that any unit test written that uses the view and manually calls the dispatch method to validate non-allowed-methods will crash with attribute not found error for request

[Adam DePue]

Test added to PR.

[Baptiste Mispelon]

There's another instance of a similar behavior in RedirectView.get: ​https://github.com/django/django/blob/master/django/views/generic/base.py#L199

Would you mind fixing that one too and adding a test for it?

Thanks.

[Tim Graham]

In addition, I was going to backport this to 1.6.X since it's a crashing issue. Could you add the following to docs/releases/1.6.1.txt as well? "Fixed a typo in :meth:django.views.generic.base.View.http_method_not_allowed that caused it to crash in some cases (#21564)." (feel free to amend as you see fit and to account for the request from bmispelon)?

[Baptiste Mispelon <bmispelon@…>]

In e2f142030b81a37e1c3187f5d336dcb6014fd1c0:

Fixed #21564 -- Use local request object when possible in generic views.

Thanks to trac user adepue for the report and original patch.