Code

Opened 5 months ago

Closed 4 months ago

#21536 closed Cleanup/optimization (worksforme)

the handler swallows exception

Reported by: wuhaochi@… Owned by: nobody
Component: Core (Other) Version: 1.6
Severity: Normal Keywords:
Cc: Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

line /Library/Python/2.7/site-packages/Django-1.6-py2.7.egg/django/core/handlers/base.py : 197.
the code is this:

        except: # Handle everything else.                                                                                                                                         
            # Get the exception info now, in case another exception is thrown later.                                                                                              
            signals.got_request_exception.send(sender=self.__class__, request=request)                                                                                            
            response = self.handle_uncaught_exception(request, resolver, sys.exc_info())     


And this haunted me quite a while when I just made a syntax mistake in my view function. Since I was reported "Server Error 500 27"
Internal Server error. But why?
When I add this block, I find the answer of my error.

      except Exception as e:                                                                                                                                                    
            import traceback                                                                                                                                                      
            traceback.print_exc(e)                                                                                                                                                
                                                                                                                                                                                  
        except: # Handle everything else.                                                                                                                                         
            # Get the exception info now, in case another exception is thrown later.                                                                                              
            signals.got_request_exception.send(sender=self.__class__, request=request)                                                                                            
            response = self.handle_uncaught_exception(request, resolver, sys.exc_info())                                                                                         


Attachments (0)

Change History (1)

comment:1 Changed 4 months ago by timo

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Resolution set to worksforme
  • Status changed from new to closed

It looks to me like you're requesting us to add logging for errors, however, if you have logging properly setup, handle_uncaught_exception() should log the error. If DEBUG=True you should get a colorful error page.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.