Opened 21 months ago

Closed 21 months ago

Last modified 21 months ago

#21511 closed Cleanup/optimization (wontfix)

django_bash_completion from pypi package install

Reported by: nekolny.brett@… Owned by: nobody
Component: Packaging Version: master
Severity: Normal Keywords:
Cc: nekolny.brett@… Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

I can't seem to get to django_bash_completion from a pypi package install of Django. I believe this is due to not including the package for "extras". Additionally, if django_bash_completion was added as an explicit script, it would be placed in the $VIRTUAL_ENV/bin/ folder for easier use.

Attachments (1)

django_bash_completion-packaging.patch (925 bytes) - added by nekolny.brett@… 21 months ago.
django_bash_completion packaging

Download all attachments as: .zip

Change History (4)

Changed 21 months ago by nekolny.brett@…

django_bash_completion packaging

comment:1 Changed 21 months ago by aaugustin

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Resolution set to wontfix
  • Status changed from new to closed

I don't think installing django_bash_completion on $PATH is a good idea. That would break dja<tab> in the shell because the autocompletion would become ambiguous: django-admin.py or django_bash_completion? And lots of people have trained their fingers to type dja<tab> :)

extras is a weird place where we put stuff that we want to keep in the repository but not ship in the packages. If you'd like to brainstorm about the best way to ship this script, could you start a discussion on the DevelopersMailingList?

comment:2 Changed 21 months ago by nekolny.brett@…

What about leaving it as an included package, but not putting it into the $PATH (not putting it in the list of "scripts" in setup.py). This way, it wouldn't disrupt the dja<tab>, but it would still be available in the virtualenv when pip installing Django?

I'd be happy to create a new patch if that was an acceptable solution.

comment:3 Changed 21 months ago by aaugustin

I don't know much about packaging best-practices. Sorry for insisting, but can you write to the django-developers mailing list?

If a consensus is found on the mailing list, please reopen this ticket.

Note: See TracTickets for help on using tickets.
Back to Top