#21488 closed Bug (fixed)
django-admin.py makemessages with commas separeted multiple locales doesn't work
| Reported by: | Romain Beylerian | Owned by: | nobody |
|---|---|---|---|
| Component: | Internationalization | Version: | 1.6 |
| Severity: | Release blocker | Keywords: | |
| Cc: | Triage Stage: | Accepted | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
Hello everyone,
The Django 1.6 documentation says that we can use the command django-admin.py makemessages with commas separated locales to specify multiple locales.
With the command django-admin.py makemessages -l en,fr, I expected Django to create two folders (en and fr) in my locale directory, howerver only one folder is created with the name en,fr.
If I repeat several times the -l option, it works. Here is an example:
$ django-admin.py makemessages -l en,fr processing locale en,fr $ django-admin.py makemessages -l en -l fr processing locale en processing locale fr
Change History (10)
comment:1 by , 12 years ago
| Severity: | Normal → Release blocker |
|---|---|
| Triage Stage: | Unreviewed → Accepted |
comment:2 by , 12 years ago
| Component: | Uncategorized → Internationalization |
|---|
comment:3 by , 12 years ago
comment:5 by , 12 years ago
Changing locale='pt,de,ch' to locale=['pt,de', 'ch'] at this line should trigger the regression for makemessages.
compilemessages test should be added to this case.
comment:6 by , 12 years ago
See https://github.com/django/django/pull/1968/files and https://github.com/django/django/pull/1969/files
We need to choose between them.
comment:7 by , 12 years ago
| Has patch: | set |
|---|
comment:8 by , 12 years ago
Considering we already support that syntax for -e, I'd vote for keeping it for -l (not a strong opinion, though).
comment:9 by , 12 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
See commit [6158c79dbef832bc85301]. Tests in that commit are using
call_command, which is not always the best way to mimic command line behaviour.