Cache tests make an incorrect use of `HttpRequest`

[Unai Zalakain]

Cache tests directly append the query string to the request path:

request = HttpRequest()
request.META = {
    'SERVER_NAME': 'testserver',
    'SERVER_PORT': 80,
}
request.method = method 
request.path = request.path_info = "/cache/%s" % path
return request

HttpRequest.get_full_path() uses the HttpRequest.META['QUERY_STRING'] attribute to determine, escape and encode the query string.

[Unai Zalakain]

PR sent: ​https://github.com/django/django/pull/1950

[Baptiste Mispelon]

Yes, it seems that the tests have accumulated some cruft over the years and they could use some cleaning up.
I'm accepting the ticket on this basis.

In particular (though the list is probably not exhaustive):

• Use django.test.RequestFactory instead of manually constructing HttpRequest objects
• Get rid of the various inconsistent _get_request method on the test cases (they have different signatures, some prepend self.path and others don't, ...)

[Unai Zalakain]

PR updated, all the _get_request mess has been substituted by django.test.client.RequestFactory ;)

[Baptiste Mispelon <bmispelon@…>]

In 2b4bed6dbd864ce78e9300f28b05045c386cd248:

Fixed #21476 -- Cache tests make an incorrect use of HttpRequest

Using django.test.client.RequestFactory solves the problem and cleans up all
the get_request mess.

[Unai Zalakain]

Thanks for the review!