Code

Changes between Initial Version and Version 1 of Ticket #21386


Ignore:
Timestamp:
11/05/13 03:01:47 (8 months ago)
Author:
bmispelon
Comment:

Yes.

This would also allow us to get rid of admindocs.views.GenericSite (it seems it was used because sites.models.RequestSite hadn't been implemented yet).

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #21386

    • Property Cc bmispelon added
    • Property Triage Stage changed from Unreviewed to Accepted
  • Ticket #21386 – Description

    initial v1  
    33But in a couple of places it uses `settings.SITE_ID` and the new 1.6 default project template settings.py doesn't include it because the sites framework isn't installed. 
    44 
    5 Perhaps it could be replaced by 'django.contrib.admindocs.models.get_current_site(request)` as suggested by https://docs.djangoproject.com/en/1.6/ref/contrib/sites/#hooking-into-the-current-site-from-views? 
     5Perhaps it could be replaced by 'django.contrib.sites.models.get_current_site(request)` as suggested by https://docs.djangoproject.com/en/1.6/ref/contrib/sites/#hooking-into-the-current-site-from-views? 
    66