admindocs 'views' section depends on SITE_ID setting
|Reported by:||ramiro||Owned by:||bouke|
|Cc:||bmispelon, bouke@…||Triage Stage:||Accepted|
|Has patch:||yes||Needs documentation:||no|
|Needs tests:||no||Patch needs improvement:||no|
Description (last modified by bmispelon)
It seems the admindocs views try to detect if th sited contrib app is installed and avoid to use its features if it's not.
But in a couple of places it uses settings.SITE_ID and the new 1.6 default project template settings.py doesn't include it because the sites framework isn't installed.
Perhaps it could be replaced by 'django.contrib.sites.models.get_current_site(request)` as suggested by https://docs.djangoproject.com/en/1.6/ref/contrib/sites/#hooking-into-the-current-site-from-views?
Change History (10)
comment:1 Changed 3 years ago by bmispelon
- Cc bmispelon added
- Description modified (diff)
- Triage Stage changed from Unreviewed to Accepted
comment:2 Changed 3 years ago by bouke
- Has patch set
- Owner changed from nobody to bouke
- Status changed from new to assigned
comment:5 Changed 2 years ago by Claude Paroz <claude@…>
- Resolution set to fixed
- Status changed from assigned to closed