#21382 closed New feature (fixed)

stacked inlines should add class "has_original" to existing fields

Reported by: jrief Owned by: ryankask
Component: contrib.admin Version: master
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

In tabular inlines one can distinguish between new and existing fields, because existing fields add the class has_original to their form row.
In stacked inlines this is not possible, there no such class is added to div.inline-related. This is inconsistent with tabular inlines and makes it impossible to distinguish between new and existing fields.

This PR: https://github.com/django/django/pull/1865 fixes it.

Change History (6)

comment:1 Changed 22 months ago by akaariai

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

comment:2 Changed 19 months ago by carljm

  • Type changed from Uncategorized to New feature

comment:3 Changed 19 months ago by timo

  • Needs tests set

comment:4 Changed 19 months ago by ryankask

  • Owner changed from nobody to ryankask
  • Status changed from new to assigned

comment:5 Changed 19 months ago by ryankask

  • Needs tests unset

I've created a new pull request with a test for the fix: https://github.com/django/django/pull/2249 (the original pull request is here: https://github.com/django/django/pull/1865)

comment:6 Changed 19 months ago by Tim Graham <timograham@…>

  • Resolution set to fixed
  • Status changed from assigned to closed

In d25622000ac8a591101ade28708d3b4b8ae4b24f:

Fixed #21382 - Added "has_original" to stacked inlines.

Report and original patch from jrief.

Note: See TracTickets for help on using tickets.
Back to Top