Code

Opened 8 years ago

Closed 8 years ago

#2138 closed defect (invalid)

auth.views small bug

Reported by: sdistefano@… Owned by: adrian
Component: contrib.admin Version:
Severity: trivial Keywords:
Cc: Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

what I've found grepping
auth/views.py:

if not errors:

# Light security check -- make sure redirect_to isn't garbage.
if not redirect_to or ':' in redirect_to or ' ' in redirect_to:

redirect_to = '/accounts/login'

is redundant.
Should be redirect_to = LOGIN_URL which is imported already.

Attachments (0)

Change History (1)

comment:1 Changed 8 years ago by adrian

  • Resolution set to invalid
  • Status changed from new to closed

No, that's incorrect. LOGIN_URL is /accounts/login. The views.py file refers to /accounts/profile.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.