Opened 18 years ago
Closed 18 years ago
#2138 closed defect (invalid)
auth.views small bug
| Reported by: | Owned by: | Adrian Holovaty | |
|---|---|---|---|
| Component: | contrib.admin | Version: | |
| Severity: | trivial | Keywords: | |
| Cc: | Triage Stage: | Unreviewed | |
| Has patch: | no | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
what I've found grepping
auth/views.py:
if not errors:
# Light security check -- make sure redirect_to isn't garbage.
if not redirect_to or ':' in redirect_to or ' ' in redirect_to:
redirect_to = '/accounts/login'
is redundant.
Should be redirect_to = LOGIN_URL which is imported already.
Note:
See TracTickets
for help on using tickets.
No, that's incorrect. LOGIN_URL is /accounts/login. The views.py file refers to /accounts/profile.