Opened 14 years ago

Closed 14 years ago

#2138 closed defect (invalid)

auth.views small bug

Reported by: sdistefano@… Owned by: Adrian Holovaty
Component: contrib.admin Version:
Severity: trivial Keywords:
Cc: Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no


what I've found grepping

if not errors:

# Light security check -- make sure redirect_to isn't garbage.
if not redirect_to or ':' in redirect_to or ' ' in redirect_to:

redirect_to = '/accounts/login'

is redundant.
Should be redirect_to = LOGIN_URL which is imported already.

Change History (1)

comment:1 Changed 14 years ago by Adrian Holovaty

Resolution: invalid
Status: newclosed

No, that's incorrect. LOGIN_URL is /accounts/login. The file refers to /accounts/profile.

Note: See TracTickets for help on using tickets.
Back to Top