Code

Opened 8 years ago

Closed 6 years ago

#2134 closed enhancement (invalid)

[patch] add comment object to comments/posted template

Reported by: md@… Owned by: nobody
Component: contrib.comments Version: master
Severity: minor Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

This patch against django svn 20060611 adds the freshly posted comment
to the 'posted' template thus allowing to show the comment or link
via an anchor to the comment. E.g.
<a href="{{ object.get_absolute_url }}#comment-{{ comment.id }}">View Comment</a>

Get it at http://c0re.23.nu/c0de/misc/django-20060611-comment-link.patch

Attachments (1)

django-20060611-comment-link.diff (2.3 KB) - added by md@… 8 years ago.
comment patch

Download all attachments as: .zip

Change History (12)

Changed 8 years ago by md@…

comment patch

comment:1 Changed 8 years ago by md@…

To be frank - I have tested this patch it only with Comments, not with FreeComments o_O.

comment:2 Changed 8 years ago by anonymous

  • Summary changed from [patch] add copmment object co comments/posted template to [patch] add comment object co comments/posted template

comment:3 Changed 8 years ago by anonymous

  • Version set to SVN

comment:4 Changed 8 years ago by test@…

  • Cc olgmnkfa, kwfuv added
  • Keywords olgmnkfa kwfuv added
  • Summary changed from [patch] add comment object co comments/posted template to olgmnkfa kwfuv

luwmod fyjgs dobip rwhtvug dipebhntu ytizran qvcolksu

comment:5 Changed 8 years ago by adrian

  • Cc olgmnkfa, kwfuv removed
  • Keywords olgmnkfa kwfuv removed
  • Summary changed from olgmnkfa kwfuv to [patch] add comment object co comments/posted template to olgmnkfa kwfuv

Reverted very witty spam.

comment:6 Changed 8 years ago by mtredinnick

  • Summary changed from [patch] add comment object co comments/posted template to olgmnkfa kwfuv to [patch] add comment object to comments/posted template

Fixed title slightly.

comment:7 Changed 8 years ago by adrian

  • Component changed from Contrib apps to django.contrib.comments

comment:9 Changed 7 years ago by Simon G. <dev@…>

  • Triage Stage changed from Unreviewed to Ready for checkin

comment:10 Changed 7 years ago by mtredinnick

  • Owner changed from adrian to jacob
  • Triage Stage changed from Ready for checkin to Accepted

Since Jacob is rewriting the comments module for 1.0, I am going to leave this alone, since the current code has a limited lifespan. We don't really have a good state to put it in, but I'll move it back to accepted and assign it to him in case there is anything useful to pull out for the new code.

comment:14 Changed 6 years ago by jacob

  • milestone 1.0 beta deleted

comment:15 Changed 6 years ago by jacob

  • Resolution set to invalid
  • Status changed from new to closed

With the new comment system added in [8557], I'm closing all comment-related tickets since they're against an old system. Please open a new ticket for this issue if it still applies in the new system.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.