Opened 18 years ago
Closed 16 years ago
#2134 closed enhancement (invalid)
[patch] add comment object to comments/posted template
| Reported by: | Owned by: | nobody | |
|---|---|---|---|
| Component: | contrib.comments | Version: | dev |
| Severity: | minor | Keywords: | |
| Cc: | Triage Stage: | Accepted | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | UI/UX: |
Description
This patch against django svn 20060611 adds the freshly posted comment
to the 'posted' template thus allowing to show the comment or link
via an anchor to the comment. E.g.
<a href="{{ object.get_absolute_url }}#comment-{{ comment.id }}">View Comment</a>
Get it at http://c0re.23.nu/c0de/misc/django-20060611-comment-link.patch
Attachments (1)
Change History (12)
by , 18 years ago
| Attachment: | django-20060611-comment-link.diff added |
|---|
comment:1 by , 18 years ago
To be frank - I have tested this patch it only with Comments, not with FreeComments o_O.
comment:2 by , 18 years ago
| Summary: | [patch] add copmment object co comments/posted template → [patch] add comment object co comments/posted template |
|---|
comment:3 by , 18 years ago
| Version: | → SVN |
|---|
comment:4 by , 18 years ago
| Cc: | added |
|---|---|
| Keywords: | olgmnkfa kwfuv added |
| Summary: | [patch] add comment object co comments/posted template → olgmnkfa kwfuv |
luwmod fyjgs dobip rwhtvug dipebhntu ytizran qvcolksu
comment:5 by , 18 years ago
| Cc: | removed |
|---|---|
| Keywords: | olgmnkfa kwfuv removed |
| Summary: | olgmnkfa kwfuv → [patch] add comment object co comments/posted template to olgmnkfa kwfuv |
Reverted very witty spam.
comment:6 by , 18 years ago
| Summary: | [patch] add comment object co comments/posted template to olgmnkfa kwfuv → [patch] add comment object to comments/posted template |
|---|
Fixed title slightly.
comment:7 by , 18 years ago
| Component: | Contrib apps → django.contrib.comments |
|---|
comment:9 by , 18 years ago
| Triage Stage: | Unreviewed → Ready for checkin |
|---|
comment:10 by , 18 years ago
| Owner: | changed from to |
|---|---|
| Triage Stage: | Ready for checkin → Accepted |
Since Jacob is rewriting the comments module for 1.0, I am going to leave this alone, since the current code has a limited lifespan. We don't really have a good state to put it in, but I'll move it back to accepted and assign it to him in case there is anything useful to pull out for the new code.
comment:14 by , 16 years ago
| milestone: | 1.0 beta |
|---|
comment:15 by , 16 years ago
| Resolution: | → invalid |
|---|---|
| Status: | new → closed |
With the new comment system added in [8557], I'm closing all comment-related tickets since they're against an old system. Please open a new ticket for this issue if it still applies in the new system.
comment patch