Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#21337 closed Bug (fixed)

backward incompability for WSGIServerException

Reported by: anonymous Owned by: nobody
Component: HTTP handling Version: 1.6-beta-1
Severity: Release blocker Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

https://github.com/django/django/commit/2ca00faa913754cd5860f6e1f23c8da2529c691a

Hi this commit is backward incompatible, I think it would be better to assign socket.error to WSGIServerException name. Or fill documentation and describe this change. I just updated from Beta 1 to RC 1 and non of my servers works.

Change History (6)

comment:1 Changed 4 years ago by Russell Keith-Magee

Component: UncategorizedHTTP handling
Severity: NormalRelease blocker
Triage Stage: UnreviewedAccepted
Type: UncategorizedBug
Version: 1.6-beta-1

I'm not in a position to check this right now, but if true, the report is a release blocker.

comment:2 Changed 4 years ago by anonymous

I'm using devserver (https://github.com/dcramer/django-devserver) and own hooked wsgiserver, changing this Exception just blow up everything. It's simple to change, but this change isn't described anywhere in the docs.

comment:3 Changed 4 years ago by Val Neekman

I have added this to deprecation.txt and issued a pull request.

comment:4 Changed 4 years ago by Baptiste Mispelon

Has patch: set

comment:5 Changed 4 years ago by Tim Graham <timograham@…>

Resolution: fixed
Status: newclosed

In aa645d20df05cdbd6ce28ff31f1cf00bd9af1e40:

[1.6.x] Fixed #21337 -- Documented removal of django.core.servers.basehttp.WSGIServerException

refs 2ca00faa913754cd5860f6e1f23c8da2529c691a

Backport of b47a052eb5 from master

comment:6 Changed 4 years ago by Tim Graham <timograham@…>

In 9074d2f5f9f32d851eb938418a77bdb24131536f:

[1.5.x] Fixed #21337 -- Documented removal of django.core.servers.basehttp.WSGIServerException

refs 2ca00faa913754cd5860f6e1f23c8da2529c691a

Backport of b47a052eb5 from master

Note: See TracTickets for help on using tickets.
Back to Top