Opened 4 years ago

Last modified 7 weeks ago

#21286 new Bug

Fix commented out tests in serializers_regress

Reported by: Tim Graham Owned by: nobody
Component: Core (Serialization) Version: master
Severity: Normal Keywords:
Cc: bmispelon@… Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no


tests/serializers_regress/ contains some commented out items in the test_data list. I think it may be because not all serializers support those items. If this is the case, we should make appropriate modifications so the tests are run where they are supported and skipped where not.

Change History (3)

comment:1 Changed 4 years ago by Baptiste Mispelon

Cc: bmispelon@… added

While looking into this, I believe I found the reason why some of the tests are commented:

The comment is not completely correct however because a few of the commented out models trigger and error immediately, regardless of the backend (TypeError: 'primary_key' is not a valid argument for ...).

  • FilePKData, ImagePKData and NullBooleanPKData can be deleted because of this.
  • DatePKData, DateTimePKData, TimePKData and TextPKData might be database-dependent (they all work under sqlite).
  • Test case 51 (FileData) might be worth looking into a bit deeper. It fails when uncommented and I believe it might be caused by the weird FileField.__eq__ implementation.

comment:2 Changed 22 months ago by Claude Paroz

FileField and NULL value issue is tracked in #10244.

comment:3 Changed 7 weeks ago by Claude Paroz <claude@…>

In d02fc8d:

Refs #21286 -- Enabled serializer tests with date/datetime pk model

Note: See TracTickets for help on using tickets.
Back to Top