Opened 17 months ago

Closed 17 months ago

Last modified 17 months ago

#21270 closed Cleanup/optimization (fixed)

pep8 cleanup: multiple statements on one line (colon)

Reported by: timo Owned by: alasdair
Component: Core (Other) Version: master
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

To find errors, ensure you have an up-to-date master with the flake8 config in setup.cfg, then remove E701 from the ignore list there. You can then run flake8 from the directory with setup.cfg in it to list all errors - there should be about 300.

Attaching an example patch to get you started.

Apply it, if you'd like:

patch -p1 -i E701.diff

Attachments (1)

E701.diff (1.8 KB) - added by timo 17 months ago.

Download all attachments as: .zip

Change History (5)

Changed 17 months ago by timo

comment:1 Changed 17 months ago by alasdair

  • Owner changed from nobody to alasdair
  • Status changed from new to assigned

I'd like to have a go at this.

comment:2 Changed 17 months ago by alasdair

Pull request: https://github.com/django/django/pull/1762

The test suite passes with the changes, but I need to configure my setup so that I can run the tests which are skipping.

comment:3 Changed 17 months ago by Alasdair Nicol <alasdair@…>

  • Resolution set to fixed
  • Status changed from assigned to closed

In eb214452c3b1dc399b629aabea926e27b5538c52:

Fixed #21270 -- Fixed E701 pep8 warnings

comment:4 Changed 17 months ago by Alex Gaynor <alex.gaynor@…>

In cce42d4cf2d6820ce04e71b7c1a785ec0d19538f:

Merge pull request #1762 from alasdairnicol/ticket_21270

Fixed #21270 -- Fixed E701 pep8 warnings

Note: See TracTickets for help on using tickets.
Back to Top