Code

Opened 9 months ago

Closed 9 months ago

Last modified 9 months ago

#21253 closed Cleanup/optimization (fixed)

PBKDF2 with cached HMAC key

Reported by: timo Owned by: nobody
Component: contrib.auth Version: master
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

50% faster than our implementation according to the pull request.

Attachments (0)

Change History (5)

comment:1 Changed 9 months ago by timo

  • Triage Stage changed from Accepted to Ready for checkin

Updated PR that applies cleanly. Presumably RFC, but waiting for a review from Donald and/or Paul.

comment:2 Changed 9 months ago by Florian Apolloner <florian@…>

  • Resolution set to fixed
  • Status changed from new to closed

In 1e4f53a6eb8d1816e51eb8bd8f95e704f6b89ead:

Fixed #21253 -- PBKDF2 with cached HMAC key

This gives a 2x speed increase compared to the existing implementation.

Thanks to Steve Thomas for the initial patch and Tim Graham for finishing it.

comment:3 Changed 9 months ago by Florian Apolloner <florian@…>

In 37aea82b1cf1175cb5d8de80fb8b0902b3d303e5:

[1.6.x] Fixed #21253 -- PBKDF2 with cached HMAC key

This gives a 2x speed increase compared to the existing implementation.

Thanks to Steve Thomas for the initial patch and Tim Graham for finishing it.

Backport of 1e4f53a6eb8d1816e51eb8bd8f95e704f6b89ead from master.

comment:4 Changed 9 months ago by Florian Apolloner <florian@…>

In 166be6a77e40a40f12c7724db6f4524babd03715:

[1.5.x] Fixed #21253 -- PBKDF2 with cached HMAC key

This gives a 2x speed increase compared to the existing implementation.

Thanks to Steve Thomas for the initial patch and Tim Graham for finishing it.

Backport of 1e4f53a6eb8d1816e51eb8bd8f95e704f6b89ead from master.

comment:5 Changed 9 months ago by Florian Apolloner <florian@…>

In c4f29c91f9ad0fc3982f785f21093ba624ead8f8:

[1.4.x] Fixed #21253 -- PBKDF2 with cached HMAC key

This gives a 2x speed increase compared to the existing implementation.

Thanks to Steve Thomas for the initial patch and Tim Graham for finishing it.

Backport of 1e4f53a6eb8d1816e51eb8bd8f95e704f6b89ead from master.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.