Opened 11 years ago
Closed 10 years ago
#21175 closed Bug (wontfix)
abstract base model classes never fire class_prepared signal
Reported by: | Carl Meyer | Owned by: | Christopher Babiak |
---|---|---|---|
Component: | Database layer (models, ORM) | Version: | 1.5 |
Severity: | Normal | Keywords: | |
Cc: | Triage Stage: | Accepted | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | yes |
Easy pickings: | no | UI/UX: | no |
Description
I can't think of a reason why this would be the preferred behavior.
In fact, ensure_default_managers
(which is one of two uses of class_prepared
in Django itself) is written with a specific case to handle abstract classes, even though it will never receive one, so clearly somebody else had an expectation that they would fire the signal too.
Change History (5)
comment:1 by , 11 years ago
Triage Stage: | Unreviewed → Accepted |
---|
comment:2 by , 11 years ago
Owner: | changed from | to
---|---|
Status: | new → assigned |
comment:3 by , 11 years ago
comment:4 by , 10 years ago
Has patch: | set |
---|---|
Patch needs improvement: | set |
Left some comments for improvement on the PR. Please uncheck "Patch needs improvement" if you can update it, thanks.
comment:5 by , 10 years ago
Resolution: | → wontfix |
---|---|
Status: | assigned → closed |
Note:
See TracTickets
for help on using tickets.
Pull request: https://github.com/django/django/pull/1916