Opened 11 years ago
Last modified 11 years ago
#21174 closed Bug
Transaction handling broken in related manager modification methods — at Version 1
| Reported by: | Anssi Kääriäinen | Owned by: | nobody |
|---|---|---|---|
| Component: | Database layer (models, ORM) | Version: | 1.6-beta-1 |
| Severity: | Normal | Keywords: | |
| Cc: | loic@… | Triage Stage: | Accepted |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description (last modified by )
Some of the related manager methods do multiple data-modifying operations but do not use any transaction management at all. This is clearly broken. This isn't a regression, so isn't a release blocker for that reason. However, this is a potential data corruption issue, so might be nice to fix for 1.6, too.
I am not sure how to test this. Maybe post_delete/save signals could be used to force exceptions and thus rollback.
EDIT: Forgot to add that a patch for some problematic methods available in https://github.com/django/django/pull/1684.
Change History (1)
comment:1 by , 11 years ago
| Description: | modified (diff) |
|---|---|
| Triage Stage: | Unreviewed → Accepted |
Note:
See TracTickets
for help on using tickets.