have LiveServerThread follow the semantics of threading.Thread.join()
|Reported by:||Louis-Dominique Dubeau||Owned by:||Unai Zalakain|
|Severity:||Normal||Keywords:||live server, test server, live wsgi|
|Cc:||unai@…||Triage Stage:||Ready for checkin|
|Has patch:||yes||Needs documentation:||no|
|Needs tests:||no||Patch needs improvement:||no|
The semantics of
threading.Thread.join() are "wait for this thread to end" and nothing more.
LiveServerThread redefines these semantics to first cause this thread to end and then wait for this thread to end.
This harms reusability, because someone calling
join() on this object would expect the regular semantics and not the Django-specific redefinition. I've encountered this bug in 1.5 but visual inspection of
master shows that at the time of writing this ticket it is present there too.
Change History (10)
comment:1 Changed 3 years ago by
|Owner:||changed from nobody to Unai Zalakain|
|Status:||new → assigned|
|Triage Stage:||Unreviewed → Accepted|