have LiveServerThread follow the semantics of threading.Thread.join()
File: django/test/testcases.py
The semantics of threading.Thread.join() are "wait for this thread to end" and nothing more.
However, LiveServerThread redefines these semantics to first cause this thread to end and then wait for this thread to end.
This harms reusability, because someone calling join() on this object would expect the regular semantics and not the Django-specific redefinition. I've encountered this bug in 1.5 but visual inspection of master shows that at the time of writing this ticket it is present there too.
Change History
(10)
| Cc: |
unai@… added
|
| Owner: |
changed from nobody to Unai Zalakain
|
| Status: |
new → assigned
|
| Triage Stage: |
Unreviewed → Accepted
|
| Keywords: |
live server test server live wsgi added
|
| Triage Stage: |
Accepted → Ready for checkin
|
| Triage Stage: |
Ready for checkin → Accepted
|
| Triage Stage: |
Accepted → Ready for checkin
|
| Resolution: |
→ fixed
|
| Status: |
assigned → closed
|
Patch: https://github.com/unaizalakain/django/tree/ticket_21172