#21152 closed Cleanup/optimization (fixed)
Small grammatical error in comment
Reported by: | Owned by: | nobody | |
---|---|---|---|
Component: | Database layer (models, ORM) | Version: | dev |
Severity: | Normal | Keywords: | grammar |
Cc: | Triage Stage: | Unreviewed | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | yes | UI/UX: | no |
Description
There's a small grammatical error in one of the comments in django.db.models.sql.subqueries.delete_qs at line 65 https://github.com/django/django/blob/master/django/db/models/sql/subqueries.py#L65
'there are no filtering' should be changed to 'there is no filtering'. Created pull request on github https://github.com/django/django/pull/1675.
Change History (3)
comment:1 by , 11 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
follow-up: 3 comment:2 by , 11 years ago
Thanks for the catch. For future reference, small fixes like these don't require a ticket here in trac.
comment:3 by , 11 years ago
Replying to ptone:
Thanks for the catch. For future reference, small fixes like these don't require a ticket here in trac.
Glad to help and thanks for the info. I only created a ticket for it because I've read the Django contrib docs on github saying that any pull request would be ignored without a ticket here.
In fd8d7db4d7f5329fc2e2b348fc60ed6e81d47b13: