Opened 23 months ago

Closed 23 months ago

Last modified 23 months ago

#21100 closed Cleanup/optimization (fixed)

1.6 Release Notes don't explicitly mention the new fields attribute on Create/UpdateViews

Reported by: AndrewIngram Owned by: nobody
Component: Documentation Version: 1.6-beta-1
Severity: Release blocker Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Django 1.6 introduces a new fields attribute on CreateView and UpdateView which is provided to the modelform_factory to limit which fields are in the generated form.

The release notes briefly mention that the attribute should be used (https://docs.djangoproject.com/en/dev/releases/1.6/#updateview-and-createview-without-explicit-fields), but makes no mention of the fact that this is new functionality (which for some reason I assumed already existed).

We simply need to add something to the release notes that explicitly highlights this.

Attachments (1)

21100.diff (1.2 KB) - added by timo 23 months ago.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 23 months ago by mjtamlyn

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted
  • Type changed from Uncategorized to Cleanup/optimization

Changed 23 months ago by timo

comment:2 Changed 23 months ago by timo

  • Has patch set

Does the attached look sufficient?

comment:3 Changed 23 months ago by mjtamlyn

LGTM

comment:4 Changed 23 months ago by Tim Graham <timograham@…>

  • Resolution set to fixed
  • Status changed from new to closed

In ec89e1725a29076d37b36f85de983b8a7cf7c329:

Fixed #21100 -- Noted that Create/UpdateViews.fields is new in 1.6

Thanks AndrewIngram for the suggestion.

comment:5 Changed 23 months ago by Tim Graham <timograham@…>

In 7a2adec4d047492ed77aa0e027d889d442b0f59c:

[1.6.x] Fixed #21100 -- Noted that Create/UpdateViews.fields is new in 1.6

Thanks AndrewIngram for the suggestion.

Backport of ec89e1725a from master

Note: See TracTickets for help on using tickets.
Back to Top