Code

Opened 10 months ago

Closed 5 months ago

#21064 closed Cleanup/optimization (fixed)

The add_view and change_view code in contrib.admin.options share the same code and need to be refactored

Reported by: kamni Owned by: kamni
Component: contrib.admin Version: master
Severity: Normal Keywords: admin
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: no UI/UX: no

Description

These should be refactored into a shared set of methods that can be unit tested and that provide one place to fix errors in the code

Attachments (0)

Change History (4)

comment:1 Changed 10 months ago by russellm

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

Agreed.

comment:2 Changed 10 months ago by kamni

  • Owner changed from nobody to kamni
  • Status changed from new to assigned

comment:3 Changed 5 months ago by timo

  • Has patch set
  • Patch needs improvement set

Comments for improvement on the PR.

comment:4 Changed 5 months ago by Tim Graham <timograham@…>

  • Resolution set to fixed
  • Status changed from assigned to closed

In 390001ce52802a7fa1fceeabfb646e6b32911fb9:

Fixed #21064 -- Refactored common logic in ModelAdmin.add_view and change_view.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.