Opened 3 years ago

Closed 3 years ago

#21064 closed Cleanup/optimization (fixed)

The add_view and change_view code in contrib.admin.options share the same code and need to be refactored

Reported by: kamni Owned by: kamni
Component: contrib.admin Version: master
Severity: Normal Keywords: admin
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: no UI/UX: no

Description

These should be refactored into a shared set of methods that can be unit tested and that provide one place to fix errors in the code

Change History (4)

comment:1 Changed 3 years ago by Russell Keith-Magee

Triage Stage: UnreviewedAccepted

Agreed.

comment:2 Changed 3 years ago by kamni

Owner: changed from nobody to kamni
Status: newassigned

comment:3 Changed 3 years ago by Tim Graham

Has patch: set
Patch needs improvement: set

Comments for improvement on the PR.

comment:4 Changed 3 years ago by Tim Graham <timograham@…>

Resolution: fixed
Status: assignedclosed

In 390001ce52802a7fa1fceeabfb646e6b32911fb9:

Fixed #21064 -- Refactored common logic in ModelAdmin.add_view and change_view.

Note: See TracTickets for help on using tickets.
Back to Top