Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#21044 closed Cleanup/optimization (fixed)

resolve reference documentation says it raises an Http404

Reported by: Keryn Knight <django@…> Owned by: Tim Graham
Component: Documentation Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

For technical correctness' sake, it actually raises a Resolver404, which subclasses Http404; this may be a distinction people are interested in, if they're using resolve.

Docs in question are ​here, linked against 1.6 for stability if the ticket is accepted and ​/dev/ changes to reflect it.

Attachments (1)

21044.diff​ (1.2 KB ) - added by Tim Graham 11 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 by Tim Graham, 11 years ago

Owner: changed from nobody to Tim Graham
Status: new → assigned
Triage Stage: Unreviewed → Accepted

by Tim Graham, 11 years ago

Attachment: 21044.diff​ added

comment:2 by Tim Graham, 11 years ago

Has patch: set

comment:3 by Keryn Knight <django@…>, 11 years ago

I'd be inclined to change line 32 to (a subclass of, but otherwise, LGTM.

comment:4 by Tim Graham <timograham@…>, 11 years ago

Resolution: → fixed
Status: assigned → closed

In eacf060e01617ea5e910e8f8a5805483cd5c60b0:

Fixed #21044 -- Documented django.core.urlresolvers.Resolver404

Thanks Keryn Knight for the suggestion.

comment:5 by Tim Graham <timograham@…>, 11 years ago

In 1dd061ad7705d2851bee5e78b9fed381130ec5f4:

[1.6.x] Fixed #21044 -- Documented django.core.urlresolvers.Resolver404

Thanks Keryn Knight for the suggestion.

Backport of eacf060e01 from master

Note: See TracTickets for help on using tickets.
Back to Top