Code

Opened 8 months ago

Closed 8 months ago

Last modified 8 months ago

#21044 closed Cleanup/optimization (fixed)

resolve reference documentation says it raises an Http404

Reported by: Keryn Knight <django@…> Owned by: timo
Component: Documentation Version: master
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

For technical correctness' sake, it actually raises a Resolver404, which subclasses Http404; this may be a distinction people are interested in, if they're using resolve.

Docs in question are here, linked against 1.6 for stability if the ticket is accepted and /dev/ changes to reflect it.

Attachments (1)

21044.diff (1.2 KB) - added by timo 8 months ago.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 8 months ago by timo

  • Needs documentation unset
  • Needs tests unset
  • Owner changed from nobody to timo
  • Patch needs improvement unset
  • Status changed from new to assigned
  • Triage Stage changed from Unreviewed to Accepted

Changed 8 months ago by timo

comment:2 Changed 8 months ago by timo

  • Has patch set

comment:3 Changed 8 months ago by Keryn Knight <django@…>

I'd be inclined to change line 32 to (a subclass of, but otherwise, LGTM.

comment:4 Changed 8 months ago by Tim Graham <timograham@…>

  • Resolution set to fixed
  • Status changed from assigned to closed

In eacf060e01617ea5e910e8f8a5805483cd5c60b0:

Fixed #21044 -- Documented django.core.urlresolvers.Resolver404

Thanks Keryn Knight for the suggestion.

comment:5 Changed 8 months ago by Tim Graham <timograham@…>

In 1dd061ad7705d2851bee5e78b9fed381130ec5f4:

[1.6.x] Fixed #21044 -- Documented django.core.urlresolvers.Resolver404

Thanks Keryn Knight for the suggestion.

Backport of eacf060e01 from master

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.