Code

Opened 8 months ago

Closed 8 months ago

Last modified 8 months ago

#21041 closed Cleanup/optimization (fixed)

Duplicate form in tests/model_forms/tests.py

Reported by: tuxcanfly Owned by: nobody
Component: Testing framework Version: master
Severity: Normal Keywords:
Cc: Triage Stage: Unreviewed
Has patch: no Needs documentation:
Needs tests: Patch needs improvement:
Easy pickings: yes UI/UX: no

Description

Very minor thing I noticed when browsing model form tests:

ArticleForm is defined here and immediately redefined:

https://github.com/django/django/blob/5649c0af9d90ba1368abbe6c233ee61c976c8137/tests/model_forms/tests.py#L110

If I'm not missing anything obvious, the redefinition is superfluous.

Attachments (0)

Change History (2)

comment:1 Changed 8 months ago by Tim Graham <timograham@…>

  • Resolution set to fixed
  • Status changed from new to closed

In bab039d74c09bfba378b7a9b4a0a6d974e20f792:

Fixed #21041 -- Removed a duplicate form in tests.

Thanks tuxcanfly.

comment:2 Changed 8 months ago by Tim Graham <timograham@…>

In 77cf0d6519c431d5411576ab5588c44971598b96:

[1.6.x] Fixed #21041 -- Removed a duplicate form in tests.

Thanks tuxcanfly.

Backport of bab039d74c from master

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.