Uploaded file's name truncates to 255 not in all cases

[homm]

If uploaded file name has very-ver long extension, it not truncates to 255 chars.

[homm]

​https://github.com/django/django/pull/1548

[Tim Graham]

Changing the file extension seems like it may not be a good idea. Did you run into a problem with this?

[homm]

What do you mean by "extension"? This patch truncate sequence of chars after last dot longer then 255 chars. Is such sequence can be called "extension"? I do not think so.

I see problem there: malefactor can send file with name longer then 255 chars. I don't know, is it problem does matter at all. If it does matter let's do strict check. If it is doesn't matter, let's remove this check at all.

[sduveen]

I don't think 'file extension' can reasonably describe anything that is over 255 chars after a dot. Patch and test look good. (refering to ​https://github.com/django/django/pull/1548/files#L0L45)

[Baptiste Mispelon]

I think the tests should be moved to file_uploads/, next to the one that tests the truncating functionality [1].

I would also rewrite them to immitate the test_filename_overflow test, which I think tests the issue more accurately: we want to make sure that an uploaded file doesn't have a name longer than 255 characters.

Thanks.

[1] ​https://github.com/django/django/blob/master/tests/file_uploads/tests.py#L168

[homm]

I update patch and move tests in file_uploads.

[Baptiste Mispelon <bmispelon@…>]

In 7008ed61c519f93a9b6c5c547ad718ad2deb959b:

Fixed #21033 -- Fixed uploaded filenames not always being truncated to 255 characters