Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#20981 closed Bug (fixed)

Documentation is misleading about default value of disable_existing_loggers

Reported by: Krzysztof Jurewicz Owned by: Krzysztof Jurewicz
Component: Documentation Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Currently the documentation states that

From Django 1.5 forward, the project’s logging configuration is merged with Django’s defaults, hence you can decide if you want to add to, or replace the existing configuration. To completely override the default configuration, set the disable_existing_loggers key to True in the LOGGING dictConfig. Alternatively you can redefine some or all of the loggers.

This suggests that the default value of disable_existing_loggers is False, which is… false, because the defalt value is true. This can easily lead to users unconsciously disabling logging at all in their projects.

Change History (4)

comment:1 by Krzysztof Jurewicz, 11 years ago

Has patch: set

I’ve created a pull request: https://github.com/django/django/pull/1516

comment:2 by Tim Graham <timograham@…>, 11 years ago

Resolution: fixed
Status: newclosed

In 095643e69145d6899313c518fdd39919c9a89908:

Fixed #20981 -- Noted the default value of disable_existing_loggers.

comment:3 by Tim Graham <timograham@…>, 11 years ago

In d3b7b6a7a452314ae12f633dec6d87b4f3465bea:

[1.5.x] Fixed #20981 -- Noted the default value of disable_existing_loggers.

Backport of 095643e691 from master

comment:4 by Tim Graham <timograham@…>, 11 years ago

In 544a190ebf53d4a6661474d3020eab2334c7f181:

[1.6.x] Fixed #20981 -- Noted the default value of disable_existing_loggers.

Backport of 095643e691 from master

Note: See TracTickets for help on using tickets.
Back to Top