#20956 closed Cleanup/optimization (invalid)
Do not check conn['ENGINE'] existence twice in django.db.utils.ConnectionHandler
Reported by: | Dima Kurguzov | Owned by: | nobody |
---|---|---|---|
Component: | Database layer (models, ORM) | Version: | 1.5 |
Severity: | Normal | Keywords: | |
Cc: | Triage Stage: | Accepted | |
Has patch: | no | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | yes | UI/UX: | no |
Description
During code surfing I found a piece of code to optimize.
In this line the conn['ENGINE']
is set to 'django.db.backends.dummy'
if it is missed.
In the next line it is checked for existence.
We can remove this check.
Change History (6)
comment:2 by , 11 years ago
Triage Stage: | Unreviewed → Accepted |
---|
comment:3 by , 11 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
comment:5 by , 11 years ago
Resolution: | fixed → invalid |
---|
Note:
See TracTickets
for help on using tickets.
Created a pull request for this ticket.